getComputedStyle crashes on some pages

[luccastera]

It happens because we are calling split on undefined on line 252. This fix checks ruleSet.selectorText before calling split on it.

[domenic]

Oh nice, great catch. Can you add a test that fails before this change, and passes after it? Let me know if you need help figuring out where to put that/how to write it.

[haraldrudell]

I had this, too.
Here's my fix:

selectors = typeof ruleSet.selectorText == 'string' ? ruleSet.selectorText.split(/\s*,\s*/) : [];

haraldrudell@21859d5

[domenic]

Ah, thanks for the reminder. It'd be awesome if either of you put together a proper pull request with tests, otherwise I'll try to get around to this soon.

[domenic]

Actually, it shouldn't be possible for selectorText to be a non-string. @chad3814, any ideas?

[domenic]

Yeah, I can't find any way to reproduce this locally guys. @dambalah, @haraldrudell if you could give me the pages where this was breaking I'd be super-grateful.

[larryaubstore]

I send you a branch with a unit test and the patch of @haraldrudell. The test will fail without the patch of @haraldrudell.