This repository has been archived by the owner on Mar 31, 2021. It is now read-only.
Updates CPI correction to handle missing data #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure where we got the numbers from, maybe using Q1 data?
There's no need to have a test for each single item in footprints.yml, it should be enough to have one test with more expects.
Before it was using global average of failing - now it uses: 1) yearly country data, 2) closest yearly country data, 3) yearly average data, 4) closest yearly average data
skovhus
reviewed
Jan 12, 2021
skovhus
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Consumer Price Indices (CPI) correction to handle situations where data is not available.
Changes
See commit messages for more detailed explanations.
#459