Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dalrymple battery to AU_battery #1519

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Add Dalrymple battery to AU_battery #1519

merged 1 commit into from
Jul 27, 2018

Conversation

lorrieq
Copy link
Collaborator

@lorrieq lorrieq commented Jul 23, 2018 •
edited

issue #1518

  • Make a function to ping specific battery units on the api

  • Return sum of battery values in the fetch function

@lorrieq
Add Dalrymple battery to AU_battery
c2d5a85 
* Make a function to ping specific battery units on the api

* Return sum of battery values in the fetch function
corradio
corradio approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@corradio corradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean. Looks good. Let's do it!

@corradio corradio merged commit 821d4db into electricitymaps:master Jul 27, 2018
@lorrieq lorrieq mentioned this pull request Jul 27, 2018
Closed
@lorrieq lorrieq deleted the dalyrmple_battery branch October 29, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corradio corradio corradio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lorrieq @corradio