bright/darkmode cookie fix #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm so the state has brightModeEnabled = false when you open the page? |
|
Ah, i misinterpreted the code. |
|
@ovbm I've fixed the cookies. However, now, when starting in darkmode, some text is still black instead of white:
|
corradio
reviewed
Sep 6, 2018
| // Observe for search query change | ||
| observe(state => state.application.searchQuery, (searchQuery, state) => { | ||
| zoneList.filterZonesByQuery(searchQuery); | ||
| }); | ||
| // Observe for brightmode change | ||
| observe(state => state.application.brightModeEnabled, (brightModeEnabled, _) => { |
There was a problem hiding this comment.
@ovbm This is the key change: I had to observe for a redux state change (before, we dispatched to redux but didn't listen to state changes)
corradio
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534
brightModeEnabled is enabled and application state now reads the cookie and sets state accordingly, I tried running this locally in chrome but it didn't open in darkmode after closing tab and reopening... any ideas?