Add JP prices #1577
Merged
Add JP prices #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmslaine
reviewed
Aug 21, 2018
parsers/JP.py
Outdated
| target_datetime = dt.datetime.now() + dt.timedelta(days=1) | ||
|
|
||
| url = 'http://www.jepx.org/market/excel/spot_{}.csv'.format( | ||
| target_datetime.year) |
There was a problem hiding this comment.
The year in the source url does not refer to calendar year, but to Japanese fiscal year, starting on Apr 1st. For example the the 2017 csv has prices from 2017/04/01 to 2018/03/31. Thus target_datetime needs to be shifted three months back before extracting year.
There was a problem hiding this comment.
Based on the graph of system price at http://www.jepx.org/ and the fact that it matches the last available day, column 6, of the csv source I am quite sure that the prices are half-hourly.
|
Well spotted @tmslaine, that's now accounted for! |
corradio
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1553
Please review:
target_datetime).Asia/Tokyowhich I have assumed is correct.