Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial translation to Croatian #1856

Merged
merged 2 commits into from
May 21, 2019
Merged

Add partial translation to Croatian #1856

merged 2 commits into from
May 21, 2019

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented May 18, 2019

  • Added Croatian to the list of languages and added a JSON template
  • Translated most of the country names and about 15 extra terms

Screenshots

image
image

@systemcatch systemcatch self-requested a review May 18, 2019 15:01
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fbarl, thanks for the contribution. Can you get the map running locally and post some screenshots. I can build the map from your branch if this isn't possible.

@fbarl
Copy link
Contributor Author

fbarl commented May 18, 2019

@systemcatch thanks for such a quick response!

I've added some screenshots to the PR description - I'm aware a lot of terms remain untranslated, but I didn't want this PR to grow too big, so I'd rather try translating the rest of it in subsequent PR(s).

Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I built the branch myself to double check everything, it looks fine.

As you say the rest of the translation can be filled in future PR's.

Copy link
Member

@corradio corradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also update mobileapp/www/index.html and mobileapp/generate-index.js ?
At some point it would make sense to unify all those.

@fbarl
Copy link
Contributor Author

fbarl commented May 20, 2019

Can you also update mobileapp/www/index.html and mobileapp/generate-index.js?

Actually I added 'hr' to locales in both of those files in the first commit. Is there anything else I missed there?

At some point it would make sense to unify all those.

Yes, I noticed that - I just opened #1862 to address it separately.

Copy link
Member

@corradio corradio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad you were right ;-)

@corradio corradio merged commit d294422 into electricitymaps:master May 21, 2019
@fbarl fbarl deleted the add-croatian-translation branch May 21, 2019 09:24
@fbarl
Copy link
Contributor Author

fbarl commented May 21, 2019

Thank you for a thorough review @systemcatch @corradio! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants