-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial translation to Croatian #1856
Add partial translation to Croatian #1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fbarl, thanks for the contribution. Can you get the map running locally and post some screenshots. I can build the map from your branch if this isn't possible.
…ry as undefined in the tooltip.
@systemcatch thanks for such a quick response! I've added some screenshots to the PR description - I'm aware a lot of terms remain untranslated, but I didn't want this PR to grow too big, so I'd rather try translating the rest of it in subsequent PR(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I built the branch myself to double check everything, it looks fine.
As you say the rest of the translation can be filled in future PR's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you also update mobileapp/www/index.html and mobileapp/generate-index.js ?
At some point it would make sense to unify all those.
Actually I added
Yes, I noticed that - I just opened #1862 to address it separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad you were right ;-)
Thank you for a thorough review @systemcatch @corradio! 👍 |
Screenshots