Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Indonesian translation in id.json #2013

Merged
merged 4 commits into from
Dec 1, 2019

Conversation

khumam
Copy link
Contributor

@khumam khumam commented Oct 4, 2019

No description provided.

@jarek
Copy link
Collaborator

jarek commented Oct 6, 2019

Hi @sahmura, thank you very much for the translation!

Could you change the following:

  • When country/region name is missing, the English name is automatically used. As far as I can tell, the country names haven't been translated to Indonesian - which is totally fine! - but in this case we should just leave out the entire zoneShortName section and it'll work the same.

Two changes that would be nice to have, but not required - we can do this for you if you're not sure what this means or how it works:

BTW, are you aware of a source of real-time electricity data for any of Indonesian regions? For example we know of http://wesm.ph/ for Philippines and https://www.gso.org.my/ for Malaysia - is there anything like this online for Indonesia?

@khumam
Copy link
Contributor Author

khumam commented Oct 6, 2019

Thank you for your feedback. I will correct it and add some translations that might still be wrong and follow your directions.

@corradio
Copy link
Member

@sahmura did you have time to look at this?

Re-Formated style and fix some words in Indonesian
@khumam
Copy link
Contributor Author

khumam commented Nov 30, 2019

Hi!

I'm so sorry I can only give feedback to you guys now because of my busy life in lectures and many projects that I'm working on. I have corrected some of the wrong words and translated all the words into Indonesian.

@khumam
Copy link
Contributor Author

khumam commented Nov 30, 2019

Thank you

@khumam
Copy link
Contributor Author

khumam commented Nov 30, 2019

Let me know what should i do next ;-)

@corradio
Copy link
Member

@corradio corradio self-requested a review November 30, 2019 16:02
@khumam
Copy link
Contributor Author

khumam commented Dec 1, 2019

Done :)

@corradio corradio merged commit 23235ab into electricitymaps:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants