Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols are not uploaded #11

Closed
erichoracek opened this issue Aug 19, 2016 · 5 comments
Closed

Symbols are not uploaded #11

erichoracek opened this issue Aug 19, 2016 · 5 comments

Comments

@erichoracek
Copy link

erichoracek commented Aug 19, 2016

The following carthage command:

carthage build ReactiveCocoa --platform ios

produces the outputs:

Carthage/Build/iOS/ReactiveCocoa.framework
Carthage/Build/iOS/ReactiveCocoa.framework.dSYM

However, invoking:

rome upload ReactiveCocoa

Only uploads the framework, not the dSYM.

It would seem that rome should cache not just .framework files matching the framework name, but rather any files matching the prefix of the framework name.

@tmspzz
Copy link
Owner

tmspzz commented Aug 19, 2016

How do you see this working in case either the framework is missing or the dSYM is missing ?

  • Should rome (upload | download) ReactiveCocoa fail if either is missing?
  • How would this work with rome list ([--missing] | [--present])?
  • When should rome report a cache miss?
  • Should this be a switch for all command in the form of `rome COMMAND --dSYM [...]`` ?

@erichoracek
Copy link
Author

Since there is not a guarantee that a dSYM will be available for a prebuilt framework in zipped GitHub releases that Carthage consumes, I don't think Rome should require symbols to be available either. It seems like Rome should just opportunistically upload all Carthage/Build products prefixed by the framework name, and do the equivalent during downloads.

With respect to the above scenario, if ReactiveCocoa.dSYM was present in the Carthage/Build directory, this would result in it being included in rome (upload|download) ReactiveCocoa, but if it was not present, it would be omitted entirely with no failures.

Since the framework is the critical artifact (dSYMs are just a nice-to-have), you would imagine that rome list would still function as it does currently.

Finally, I don't think this should be a command line switch to follow the precedence of Carthage, which does this automatically without user intervention.

Hope that helps clear things up. Thanks!

@tmspzz tmspzz added this to the Upload dSYMs milestone Aug 20, 2016
@tmspzz
Copy link
Owner

tmspzz commented Aug 21, 2016

Hi, this will be the next feature once the Romefile has moved to the INI format.

  • For contributors: dSYM are found in the same directory as the frameworks and must be zipped as well.

@tmspzz tmspzz mentioned this issue Aug 22, 2016
@tmspzz
Copy link
Owner

tmspzz commented Aug 23, 2016

Available in pre-release https://github.com/blender/Rome/releases/tag/v0.5.0.6

@tmspzz
Copy link
Owner

tmspzz commented Aug 25, 2016

Available from https://github.com/blender/Rome/releases/tag/v0.5.0.7 onwards

@tmspzz tmspzz closed this as completed Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants