Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fallback for processors without SSE 4.1 #3

Closed
silasdavis opened this issue Oct 31, 2018 · 1 comment
Closed

Consider fallback for processors without SSE 4.1 #3

silasdavis opened this issue Oct 31, 2018 · 1 comment

Comments

@silasdavis
Copy link

silasdavis commented Oct 31, 2018

I completely understand that this may be a non-goal for this project, but it would be useful for our usage if go-hex would fallback to stdlib encoding/hex when the processor does not support the necessary instructions.

When I adopted go-hex I didn't take the time to appreciate that this codec will fail on older processors. I might not have made the leap if I realised it would exclude some processors/people from running my code. It looks like processors dating to before 2007/8 would be affected by this. For reference here is our bug report that alerted us to this: hyperledger-archives/burrow#905

I guess this depends on how hard it would be to introduce a fallback and whether that would incur significant additional runtime cost, which I am not sure about. Please feel free if to just close this issue if you consider it out of scope - I just thought it was worth raising.

@tmthrgd
Copy link
Owner

tmthrgd commented Nov 1, 2018

A decade old CPU isn't something I exactly expected to come across. The fix isn't too difficult so I will include it.

@tmthrgd tmthrgd closed this as completed in 14226a5 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants