Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Users Can View Tasks From a different Workspace with Another Selected #66

Closed
tpjnorton opened this issue Mar 8, 2022 · 1 comment
Closed

Users Can View Tasks From a different Workspace with Another Selected #66

tpjnorton opened this issue Mar 8, 2022 · 1 comment
Labels
bug Something isn't working
Projects
GA 2

Comments

@tpjnorton
Copy link
Owner

Basically, If I'm a member of workspace A and workspace B, I shouldn't be able to go to /tasks/[some task in workspace b] if i'm currently viewing workspace A.

From an API perspective it's not illegal, it's just weird UX.
@tpjnorton tpjnorton added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 8, 2022
@tpjnorton tpjnorton added this to To do in Beta 1 - LA via automation Mar 8, 2022
@tpjnorton tpjnorton added this to To do in GA via automation Mar 8, 2022
@tpjnorton tpjnorton removed this from To do in GA Mar 8, 2022
@tpjnorton tpjnorton removed this from To do in Beta 1 - LA Mar 17, 2022
@tpjnorton tpjnorton added this to To do in GA via automation Mar 17, 2022
@tpjnorton tpjnorton mentioned this issue Mar 24, 2022
Closed
2 tasks
@tpjnorton
Copy link
Owner Author

Potential solution:

Send the currently active workspace ID as a header in requests.

We DON'T want to use this in the API.

This is for getServerSideProps only to make a call to know if the task being loaded matches the current workspace. We don't save a DB call, but we could use this to also make plan-sensitive decisions server-side too.

@tpjnorton tpjnorton removed this from To do in GA Mar 26, 2022
@tpjnorton tpjnorton added this to To do in GA 2 via automation Mar 26, 2022
GA 2 automation moved this from To do to Done Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
GA 2
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpjnorton