Add an itau argument to BiCopSelect, RVineCopSelect and RVineStructureSelect #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement this, I suggest the following:
You can compare the speed of using itau instead of mle using the examples from RVineCopSelect/RVineStructureSelect:
system.time(RVM <- RVineStructureSelect(daxreturns, c(1,3:6)))
system.time(RVM <- RVineStructureSelect(daxreturns, c(1:6), method = "itau"))
system.time(RVM <- RVineStructureSelect(daxreturns, c(1, 3:6), method = "itau"))
system.time(RVM1 <- RVineCopSelect(simdata, familyset = c(1, 3, 4, 5 ,6), Matrix))
system.time(RVM1 <- RVineCopSelect(simdata, familyset = c(1:6), Matrix, method = "itau"))
system.time(RVM1 <- RVineCopSelect(simdata, familyset = c(1, 3, 4, 5 ,6), Matrix, method = "itau"))
Note that it generates a warning (as expected) when method = "itau" and familyset = 1:6.
As an additional suggestion, in RVineStructureSelect/fit.ACopula, it's probably not worth calling BiCopSelect and BiCopHfunc1/2 when familyset == 0.