fix: publicise generated enum maps to enable reuse #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnc1997
changed the title
tnc1997
approved these changes
Oct 29, 2022
There was a problem hiding this comment.
Hello @Skycoder42, thank you very much for your contribution, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Replace all occurances of
_$XXXEnumMapwith$XXXEnumMap.Current behavior
Enum maps are library private, making it impossible to reuse enums across multiple files.
New behavior
Enums files are now library public, allowing to spread them into multiple files and reuse them for multiple elements.
Additional context
Fixes #28
I did update and run all tests and regenerated the example .g files to ensure the changes work