Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] toolbar option buttons should be visible for any frame size #33

Closed
anamak9 opened this issue May 2, 2021 · 4 comments
Closed
Assignees
Labels
awaiting-response Awaiting response from OP bug Something isn't working

Comments

@anamak9
Copy link

anamak9 commented May 2, 2021

Describe the bug
defaultToolbarButtons not visible for all types.

To Reproduce
Steps to reproduce the behavior:
See screenshot below

Expected behavior
All toolbar options should be fitted for any dimensions available

Screenshots
toolbar-issue

Device:
Android emulator

Additional context
Version:
html_editor_enhanced: ^2.0.1

I think it used work fine in two versions prior this one.

@anamak9 anamak9 added the bug Something isn't working label May 2, 2021
@tneotia
Copy link
Owner

tneotia commented May 2, 2021

Hi there, please use toolbarType: ToolbarType.nativeGrid to be able to see all the buttons visible (like previous versions):

Html(
   //other options
   htmlToolbarOptions: HtmlToolbarOptions(
      //other options
      toolbarType: ToolbarType.nativeGrid,
   )
),

By default the package uses a horizontal scrollable widget to show the toolbar items.

@tneotia tneotia added the awaiting-response Awaiting response from OP label May 3, 2021
@anamak9
Copy link
Author

anamak9 commented May 5, 2021

Yes that worked but it would be nice to have all options collapsible wherever possible.

toolbar-fixed

btw what is that divider kind of thing (inside the red circle) ? how do we tweak it for its size etc?

@tneotia
Copy link
Owner

tneotia commented May 5, 2021

It is just there because it is part of the Summernote editor (see https://summernote.org/ shows the same divider). If you want it to disappear, set the editor "fullscreen" with <controller>.setFullscreen() in the onInit callback. (see #4 for more details).

Yes that worked but it would be nice to have all options collapsible wherever possible.

I don't know how this would work but I'll consider it as a feature request. Please make a feature request issue with some more details and I'll look into it :)

Closing this issue as it is resolved.

@tneotia tneotia closed this as completed May 5, 2021
@tneotia
Copy link
Owner

tneotia commented Jun 13, 2021

@anamak9 here's what I came up with for expandable/collapsible options:

device-2021-06-13-195503.mp4

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Awaiting response from OP bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants