Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do refresh in background #7

Closed
vladholubiev opened this issue Jan 22, 2015 · 5 comments
Closed

Do refresh in background #7

vladholubiev opened this issue Jan 22, 2015 · 5 comments
Labels
bug

Comments

@vladholubiev
Copy link
Member

Currently refreshing is in main UI thread. Need to move it to background thread in order to get rid of freezing the UI.
@vladholubiev
Copy link
Member Author

Freezing the UI was caused by abnormal work of Garbage Collector which is fixed now.

@vladholubiev vladholubiev reopened this Feb 9, 2015
@vladholubiev
Copy link
Member Author

No. It is because of blocking a main (UI) thread by AsyncTask#get(). Probably wont fix. Users report that lag has an effect of doing something important.

@hermanstankov
Copy link

> wont fix
> effect of doing something important
> freezing the ui thread

Wtf? Why wouldn't you just fix this issue? It is a bad practice. The Refresh button is unresponsive for now.

@vladholubiev
Copy link
Member Author

Thanks, @Filutkie. Your reasoned statement motivated me. I was sure in complexity of this task and wrote that flimsy pretext to abandon the issue, but in fact the solution boiled down to some sort of callbacks. Fixed now.

@vladholubiev
Copy link
Member Author

Due to migration to new JSON API this bug regressed again.

@vladholubiev vladholubiev reopened this Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hermanstankov @vladholubiev