Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Ivy support #157

Closed
PxyUp opened this issue Jun 10, 2020 · 5 comments
Closed

Need Ivy support #157

PxyUp opened this issue Jun 10, 2020 · 5 comments
Labels
Status: Needs Triage We need to properly tag this issue Type: Feature If you want to add something that doesn't exist yet

Comments

@PxyUp
Copy link

PxyUp commented Jun 10, 2020

Hello, first of all, thank you very much for really nice library it works perfectly, but after migration on 9 angular it is not working(i enable ivy). May be team can be provide that support:

    ERROR in node_modules/@ngqp/core/lib/query-param.module.d.ts:3:22 - error NG6002: Appears in the NgModule.imports of ApplicationsModule, but could not be resolved to an NgModule class.
    
    This likely means that the library (@ngqp/core) which declares QueryParamModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
@PxyUp PxyUp added Status: Needs Triage We need to properly tag this issue Type: Feature If you want to add something that doesn't exist yet labels Jun 10, 2020
@PxyUp
Copy link
Author

PxyUp commented Jun 10, 2020

If it will help for you i can provide MR

@Airblader
Copy link
Collaborator

Thanks for reporting this issue! Which version exactly are you using of ngqp according to your lock file? Can you try reinstalling it? I use ngqp on an Ivy project myself so I do know that it works in general. :-)

@PxyUp
Copy link
Author

PxyUp commented Jun 10, 2020

    "@ngqp/core": {
      "version": "1.0.2",
      "resolved": "https://registry.npmjs.org/@ngqp/core/-/core-1.0.2.tgz",
      "integrity": "sha512-NJ5ktrQwv7mRsmcOlA2ueTceI+vThSKhiQEzSJIlLtcHCLE26S7Zb8h4Gn40KlPYxC58fROGRAHqHKW6wdbcYw==",
      "requires": {
        "schematics-utilities": "^1.1.2",
        "tslib": "^1.9.0"
      }
    },

@PxyUp
Copy link
Author

PxyUp commented Jun 10, 2020

Sorry my bad, i move it lazy load module ;)

@PxyUp PxyUp closed this as completed Jun 10, 2020
@Airblader
Copy link
Collaborator

Glad you got it to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage We need to properly tag this issue Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

2 participants