New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is the relayState attribute a part of EntitySettings? #163
Comments
@osuvaldo90 I quickly review the code, in fact, right now you can pass the const sp = serviceProvider({
relayState: ...
}); |
Thanks @tngan. My concern is mainly with using Additionally, I began working on a solution to #157 and encountered the following TypeScript error when attempting to pass in
const sampleRelayState = 'SampleRelayState'
const spNoAssertSignCustomConfig = serviceProvider({
...defaultSpConfig,
metadata: spmetaNoAssertSign,
signatureConfig: {
prefix: 'ds',
location: { reference: '/samlp:Response/saml:Issuer', action: 'after' },
},
relayState: sampleRelayState
}); |
The SAML 2.0 Wikipedia page seems to imply that |
Sorry for the late reply. Thanks for catching this. Yes, it would be good to move it into request level instead of entity level. |
I monkey patch the sp.entitySetting.relayState = "http://example.com";
sp.createLoginRequest(idp, 'redirect'); (omitted code for restoring relayState value) Would a change to move this to a parameter for Thanks! |
@eliasson Yes, this is a mistake when I have designed the interface. I will find a way to put it back to request level. |
I was just looking for a way to pass a returnurl to the login request and the relay state seems like what people use. Is there any progress on this since the last comment? I assume it’s not an easy fix |
@tngan Is there any progress on this issue? |
Do you need help implementing this ? |
@ABitShift Yes, feel free to submit a PR, thanks for recalling this. |
Perhaps it is my misunderstanding of the SAML protocol but it seems as if it would make more sense to have
relayState
as a parameter tocreateLoginRequest()
.The text was updated successfully, but these errors were encountered: