Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLL Routine Rung Comment Generation #15

Closed
Ryushi5 opened this issue Mar 22, 2024 · 5 comments
Closed

RLL Routine Rung Comment Generation #15

Ryushi5 opened this issue Mar 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Ryushi5
Copy link

Ryushi5 commented Mar 22, 2024

I have run into an issue when creating a new RLL Routine and adding a commented Rung.

In L5X output, the Comment element is added after the Text element. When importing into Studio 5000 (v33.11), it gives the following error:

Element <Comment> is in the wrong order.

If I manually swap the order in the L5X, everything imports correctly. Is there something I can do to re-order the way the rung tags are generated?

@tnunnink
Copy link
Owner

tnunnink commented Mar 22, 2024

Hey,

No, I think this is a bug. Thanks for reporting it. I will look to see if I can get it fixed here shortly.

@tnunnink tnunnink self-assigned this Mar 22, 2024
@tnunnink tnunnink added the bug Something isn't working label Mar 22, 2024
@Ryushi5
Copy link
Author

Ryushi5 commented Mar 22, 2024

Thank you sir!

@tnunnink
Copy link
Owner

Okay try upgrading to 0.19.6 and see if that fixes it. The Comment element should now always appear first before the Text element, regardless of when it is set. I added some tests to make sure.

@Ryushi5
Copy link
Author

Ryushi5 commented Mar 22, 2024

Confirmed: running the same generation with version 0.19.6 has the Comment tag first, and was successfully imported into Studio 5000.

Thank you again!

@Ryushi5 Ryushi5 closed this as completed Mar 22, 2024
@tnunnink
Copy link
Owner

Awesome! No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants