Skip to content

Commit

Permalink
Add missing test for atomic update set method (#218)
Browse files Browse the repository at this point in the history
Thanks @efagerberg for the patch!
  • Loading branch information
Evan Fagerberg authored and acdha committed Apr 7, 2017
1 parent bb4748a commit 58a80e1
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ def test_add_with_boost(self):
self.assertEqual(len(res), 5)
self.assertEqual('doc_6', res.docs[0]['id'])

def test_field_update(self):
def test_field_update_inc(self):
originalDocs = self.solr.search('doc')
self.assertEqual(len(originalDocs), 3)
updateList = []
Expand All @@ -601,6 +601,25 @@ def test_field_update(self):
self.assertEqual(True, all(updatedDoc[k] == originalDoc[k] for k in updatedDoc.keys()
if k not in ['_version_', 'popularity']))

def test_field_update_set(self):
originalDocs = self.solr.search('doc')
updated_popularity = 10
self.assertEqual(len(originalDocs), 3)
updateList = []
for i, doc in enumerate(originalDocs):
updateList.append({'id': doc['id'], 'popularity': updated_popularity})
self.solr.add(updateList, fieldUpdates={'popularity': 'set'})

updatedDocs = self.solr.search('doc')
self.assertEqual(len(updatedDocs), 3)
for i, (originalDoc, updatedDoc) in enumerate(zip(originalDocs, updatedDocs)):
self.assertEqual(len(updatedDoc.keys()), len(originalDoc.keys()))
self.assertEqual(updatedDoc['popularity'], updated_popularity)
# TODO: change this to use assertSetEqual:
self.assertEqual(True, all(updatedDoc[k] == originalDoc[k] for k in updatedDoc.keys()
if k not in ['_version_', 'popularity']))

def test_field_update_add(self):
self.solr.add([
{
'id': 'multivalued_1',
Expand Down

0 comments on commit 58a80e1

Please sign in to comment.