Django: fixes pagination parameter #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job @cawal! |
seocam
requested changes
Nov 22, 2021
restless/dj.py
Outdated
| @@ -28,7 +28,7 @@ def serialize_list(self, data): | |||
| page_size = getattr(self, 'page_size', getattr(settings, 'RESTLESS_PAGE_SIZE', 10)) | |||
| paginator = Paginator(data, page_size) | |||
|
|
|||
| page_number = self.request.GET.get('p', 1) | |||
| page_number = int(self.request.GET.get('p', 1)) | |||
There was a problem hiding this comment.
We also need to treat the error in case the cast is not possible.
cawal
force-pushed
the
fix-page-param
branch
from
7e22d4f
to
119837d
Compare
seocam
approved these changes
Dec 23, 2021
|
We need to rebase and to get tests running. I'm not sure why the tests are not running. |
When a user pass the `p` parameter in query, Django returns a string. The string needs to be casted to integer in order to be used in the paginator. Otherwise, the response returns BadRequest.
cawal
force-pushed
the
fix-page-param
branch
from
119837d
to
445196c
Compare
|
Rebased. =] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user pass the
pparameter in query,Django returns a string. The string needs to be
casted to integer in order to be used in the paginator.
Otherwise, the response returns BadRequest.