Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dj.py for supporting latest Django #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nhridoy
Copy link

@nhridoy nhridoy commented Sep 20, 2022

Change One:
restless/restless/dj.py
from django.conf.urls import url ❌
from django.urls import re_path ✔️

url(r'^$', cls.as_list(), name=cls.build_url_name('list', name_prefix)), ❌
re_path (r'^$', cls.as_list(), name=cls.build_url_name('list', name_prefix)), ✔️

url(r'^(?P<pk>[\w-]+)/$', cls.as_detail(), name=cls.build_url_name('detail', name_prefix)), ❌
re_path (r'^(?P<pk>[\w-]+)/$', cls.as_detail(), name=cls.build_url_name('detail', name_prefix)), ✔️

Change Two:
Refactor codes

@tianfan
Copy link

tianfan commented Jan 31, 2023

I am wondering if this pull request done? Can the admin merge the pull request? this is an important change.

@jseadragon jseadragon mentioned this pull request Jul 6, 2023
@jeromelefeuvre
Copy link

More than 1 years and not yet merged! Hey @toastdriven, can you do something or add more collaborators to merge this! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants