Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github revisions backend not working #155

Closed
staticfloat opened this issue Oct 18, 2013 · 4 comments
Closed

github revisions backend not working #155

staticfloat opened this issue Oct 18, 2013 · 4 comments
Assignees

Comments

@staticfloat
Copy link
Contributor

At first, I had my github url set to http://github.com/JuliaLang/julia.git, but that didn't work because the github API doesn't like the .git ending when asking for commits. Try these two links for a demonstration: [doesn't work](https://api.github.com/repos/JuliaLang/julia.git/git/commits/7eb0ad291baa0000d2d934b32f
61a4d327ae142c), [works](https://api.github.com/repos/JuliaLang/julia/git/commits/7eb0ad291baa0000d2d934b32f
61a4d327ae142c).

Once I had fixed that, I noticed I still get errors in my server logs:

RROR:root:Unhandled Exception on request for http://julia-codespeed.csail.mit.edu/changes/logs/?revisionid=46
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 115, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/codespeed-0.9.1-py2.7.egg/codespeed/views.py", line 781, in displaylo
gs
    log['commit_browse_url'] = project.commit_browsing_url.format(**log)
KeyError: u'commitid'

Since I remembered commitid being something the recent github API pull request mentioned, I thought this might be some case that fell through the cracks. Ideas?

@staticfloat
Copy link
Contributor Author

It looks like this happens when the "Changes" view tries to pull down the commit log for whatever revision it's looking at.

@tobami
Copy link
Owner

tobami commented Oct 20, 2013

I hadn't encountered such a problem myself, but it could well be a bug introduced from the recent upgrade to Github's API v3.

@nomeata
Copy link
Contributor

nomeata commented Jul 17, 2014

It works for me.

@tobami tobami self-assigned this Mar 21, 2015
@tobami
Copy link
Owner

tobami commented Mar 22, 2015

It does work as of master

@tobami tobami closed this as completed Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants