Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single line of lore does not displayed #1

Closed
Ling-Ink opened this issue Aug 5, 2023 · 4 comments
Closed

Single line of lore does not displayed #1

Ling-Ink opened this issue Aug 5, 2023 · 4 comments

Comments

@Ling-Ink
Copy link
Contributor

Ling-Ink commented Aug 5, 2023

I was following the User Beginner Guide and I found when I add single lore to a item, it does not displayed
image
image

I found that ParserContext.getOptionalStringArray() used foreach to process the lore array, but when there have only one lore, the getOptionalNode() returned JsonNode is String instead of Array
image
image

@ToberoCat
Copy link
Owner

Thanks for reporting this issue. I'll take a look at fixing it right now.

@Ling-Ink
Copy link
Contributor Author

Ling-Ink commented Aug 5, 2023

This is my solution:
image
It works correctly

@ToberoCat
Copy link
Owner

Thanks I've used your implementation with some minor changes. Bug will now be fixed in the newer version of the plugin

@ToberoCat
Copy link
Owner

If you happen to come across a bug and manage to resolve it locally, please feel free to submit a pull request.

@Ling-Ink Ling-Ink closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants