Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically disable C extensions on PyPy #41

Closed
thedrow opened this issue Jun 20, 2015 · 4 comments
Closed

Automatically disable C extensions on PyPy #41

thedrow opened this issue Jun 20, 2015 · 4 comments

Comments

@thedrow
Copy link

thedrow commented Jun 20, 2015

Using a CPython extension on PyPy will slow this module down.

@tobgu
Copy link
Owner

tobgu commented Jun 20, 2015

Yes, for sure. Do you have an example where the C extension is built when installing pyrsistent under PyPy? It's meant not to.

@thedrow
Copy link
Author

thedrow commented Jun 20, 2015

What you need to do is just modify https://github.com/tobgu/pyrsistent/blob/master/setup.py#L46 to check if running on PyPy like this.

@tobgu
Copy link
Owner

tobgu commented Jun 20, 2015

Do you mean that https://github.com/tobgu/pyrsistent/blob/master/setup.py#L17 is not working for you?

@thedrow
Copy link
Author

thedrow commented Jun 20, 2015

Oh I did not notice that.

@thedrow thedrow closed this as completed Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants