Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox Preview : impossible to retrieve url from Github error #6

Closed
florian-s-code opened this issue May 13, 2020 · 2 comments
Closed

Firefox Preview : impossible to retrieve url from Github error #6

florian-s-code opened this issue May 13, 2020 · 2 comments

Comments

@florian-s-code
Copy link

florian-s-code commented May 13, 2020 •
edited
Loading

Hi, thanks for the new version ! Great improvement in quality and usefulness ! The download works for "classic" Firefox .

Unfortunately, the app fails to retrieve the download link for Firefox Preview.
Instead there are 2 error messages :
"Impossible to retrieve the url from Github" (translation to English from another language)
"Installation of the app has not succeeded. You can close this screen." (translation to English from anther language)

Same result for Firefox Preview 4.5.0 a few days ago and 5.0.0 now.

Version of the app: 68.0 (f-droid)
Android version: 9 (LineageOS 16.0)
@Tobi823
Copy link
Owner

Tobi823 commented May 13, 2020

Can you uninstall and reinstall the app? I know it sounds crazy but it worked on my smartphone.

I think this bug is caused by the new app trying to read the old settings. Because debugging this strange error is more difficult, I planned to do it but I forgot it 🙈

Other possibility: You are temporary blocked by Github for an hour. Can you visit https://api.github.com/rate_limit and check this?
2020-05-13 21_35_30-Mozilla Firefox

@Tobi823
Copy link
Owner

Tobi823 commented May 13, 2020

Nevermind - this is a different bug.

The app searches in https://api.github.com/repos/mozilla-mobile/fenix/releases/latest for assets containing "aarch64" in there name.

But the name of the asset (e.g. "firefox_preview_v5.0_arm64.apk") for modern 64bit ARM CPUs contains "arm64" and not "aarch64".

That's the problem when testing with x86_64 android emulators only 😬

I will add some tests and release a new version

Tobi823 pushed a commit that referenced this issue May 13, 2020
#6
0c3a9ac 
- fix bug "Firefox Preview : impossible to retrieve url from Github error"
  - reason: check for arm64 assets was not correct
- add integration tests to make sure, that this bug will never occur again
Tobi823 pushed a commit that referenced this issue May 13, 2020
#6
9c253cd 
- improve Github REST API parser to identify the correct asset for the device
  - rewrite to make the code more understandable
Tobi823 pushed a commit that referenced this issue May 13, 2020
#6
be1264f 
- fix integration test
Tobi823 pushed a commit that referenced this issue May 13, 2020
#6
2f6725b 
- add integration tests
Tobi823 pushed a commit that referenced this issue May 13, 2020
#6
832333d 
- release new version
@Tobi823 Tobi823 closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florian-s-code @Tobi823