Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar improvements in JFX 19 #63

Open
1 of 2 tasks
tobiasdiez opened this issue Jul 10, 2022 · 6 comments
Open
1 of 2 tasks

Similar improvements in JFX 19 #63

tobiasdiez opened this issue Jul 10, 2022 · 6 comments
Labels
status: help wanted Extra attention is needed type: documentation Improvements or additions to documentation type: enhancement New feature or request

Comments

@tobiasdiez
Copy link
Owner

tobiasdiez commented Jul 10, 2022

There have been recently similar improvements to the core of JFX: openjdk/jfx@60c75b8

Todo:

  • Point people to the new methods in the readme: EasyBind.map (similar to map but differs in handling of null) and EasyBind.mapObservable (similar to flatMap, but different handling of null)
  • Keep compatibility due to conflicting name: done in Compatibility with jfx19 #68
@tobiasdiez tobiasdiez added type: documentation Improvements or additions to documentation type: enhancement New feature or request status: help wanted Extra attention is needed labels Jul 10, 2022
@tobiasdiez tobiasdiez changed the title Similar improvements in JFX Similar improvements in JFX 19 Aug 16, 2022
@Siedlerchr
Copy link

Easiest way: Rename the methods to avoid ambiguity.
We can deprecate map and flatMap, I think.
I would keep the OptionalBinding as there is no equivalent.

@Siedlerchr
Copy link

For testing with javafx19, it's easiest way is to use the javafx plugin for gradle and set the version to '19-ea+10' https://mvnrepository.com/artifact/org.openjfx/javafx-base/19-ea+10

@tobiasdiez
Copy link
Owner Author

Renaming sounds like a good idea indeed.

@tobiasdiez
Copy link
Owner Author

@Siedlerchr the new snapshot should be compatible with jfx 19. Can you please test this with JabRef?

@Siedlerchr
Copy link

Will test later this evening.

@Siedlerchr
Copy link

I noticed there was one or Else method that Still clashed. Created a follow up pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Extra attention is needed type: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants