Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bikeshed include files. #27

Open
frivoal opened this issue Jan 30, 2019 · 5 comments
Open

Support bikeshed include files. #27

frivoal opened this issue Jan 30, 2019 · 5 comments

Comments

@frivoal
Copy link

frivoal commented Jan 30, 2019

https://api.csswg.org/bikeshed/ and https://github.com/tobie/pr-preview/ are a great combo, except that in addition to my index.bs file, I have local custom *.include files, and if these don't stay together with the spec, the result isn't the intended one.

(cc @plinss) https://api.csswg.org/bikeshed/ should be patched to allow uploading multiple files so that I can do something like:

curl https://api.csswg.org/bikeshed/ -F file=@index.bs -F file=@header.include file=@footer.include -F force=1 > index.html

Then https://github.com/tobie/pr-preview/ should be updated to support that.

jyasskin added a commit to jyasskin/pr-preview that referenced this issue May 9, 2020
Fixes tobie#27.

This depends on a to-be-added extension to
http://hg.csswg.org/dev/bikeshed-web/ to accept an include_urls[] query
parameter.
@jyasskin
Copy link
Contributor

jyasskin commented May 21, 2020

I'm doing this in 3 parts:

@tobie
Copy link
Owner

tobie commented May 21, 2020

Note that now that we’ve collected the array of urls for the includes, we can also pass them as part of the query parameters if that’s easier to implement in bikeshed.

@jyasskin
Copy link
Contributor

It was easier for Bikeshed to just look things up relative to the input URL.

@frivoal, your use case is going to require you to list the custom boilerplate files in the Local Boilerplate metadata.

@jyasskin
Copy link
Contributor

jyasskin commented Jun 1, 2020

Success! https://pr-preview.s3.amazonaws.com/jyasskin/privacy-threat-model/pull/30.html#model-cross-site-recognition

Thanks everyone (@tobie, @plinss, @tabatkins, @marcoscaceres, @sidvishnoi) for the design help and reviews!

@tobie
Copy link
Owner

tobie commented Jun 1, 2020

This is so awesome! Congrats!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants