Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Installer running under Windows is not recognized #1

Open
esb opened this issue Apr 19, 2011 · 2 comments
Open

Ruby Installer running under Windows is not recognized #1

esb opened this issue Apr 19, 2011 · 2 comments

Comments

@esb
Copy link

esb commented Apr 19, 2011

Running tests using the Ruby Installer version of ruby under Windows do not correctly recognize the host version string.

The code in 'lib\unittest_js\browsers\abstract.rb' needs to be updated as follows:

def windows?
host.include?('mswin') or host.include?('mingw32')
end

This adds the 'mingw32' version string that is used in this version of ruby.

@tobie
Copy link
Owner

tobie commented Apr 20, 2011

Would you please send me a pull request?

@esb
Copy link
Author

esb commented Apr 20, 2011

Hi,

Sorry, I don't have a cloned version of the project. It's just a 1-line
update so it's not really worth the effort of setting one up for just that.

Cheers,
Brian

On 20/04/2011 16:27, tobie wrote:

Would you please send me a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants