Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kirby v4 support #12

Closed
2 tasks done
tobimori opened this issue May 25, 2023 · 6 comments
Closed
2 tasks done

Kirby v4 support #12

tobimori opened this issue May 25, 2023 · 6 comments
Labels
type: roadmap 🏁 Is a long-term planned change
Milestone

Comments

@tobimori
Copy link
Owner

tobimori commented May 25, 2023

@tobimori tobimori added the type: roadmap 🏁 Is a long-term planned change label May 25, 2023
@tobimori tobimori added this to the 1.0.0 milestone May 25, 2023
@tobimori tobimori pinned this issue May 25, 2023
@andreasba
Copy link

@tobimori a big Dankeschön from my side for this plugin! I researched it a bit and I think yours is the most uptodate, modern one and I really like the approach.

I am writing just to confirm that I successufully testing your plugin on the current alpha-5 of Kirby 4 👍

@tobimori
Copy link
Owner Author

I am writing just to confirm that I successufully testing your plugin on the current alpha-5 of Kirby 4 👍

Thank you! With alpha.5 there are some visual bugs due to changed classes, but the plugin should work well besides that.

@jonasfeige
Copy link

On alpha.6, the plugin works mostly fine for me as well!
I am getting an error for the ogImage field though:

Invalid field type ("ogImage")

@tobimori
Copy link
Owner Author

hm, interesting - i'm running it all fine with Kirby 4 Alpha 6 on the latest plugin version.

@jonasfeige
Copy link

jonasfeige commented Aug 10, 2023

It seems to be my config settings. If I delete them, everything works fine. Do you see anything wrong with these?

config.php

<?php 

return [
  'tobimori.seo' => [
      'lang' => 'de_DE',
      'robots' => [
        'sitemap' => 'sitemap.xml'
      ],
      'files' => [
        'template' => 'image'
      ]
  ]
];

@tobimori
Copy link
Owner Author

tobimori commented Sep 7, 2023

0.4.0 will be the first Kirby 4 only release which should work and fixes visual bugs.

@tobimori tobimori closed this as completed Sep 7, 2023
@tobimori tobimori unpinned this issue Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: roadmap 🏁 Is a long-term planned change
Projects
None yet
Development

No branches or pull requests

3 participants