Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Release for APIv8 Depreciation #41

Closed
angry-bender opened this issue Apr 26, 2024 · 20 comments
Closed

Updated Release for APIv8 Depreciation #41

angry-bender opened this issue Apr 26, 2024 · 20 comments

Comments

@angry-bender
Copy link
Contributor

I noticed @matejcerny was able to upgrade the API to v9 2 days ago.

Just wondering if @tobimori can look to release an updated compiled version for the Elgato store before the upcoming V8 API depreciation on May16? As per PR #40 or if we should look to compile locally?

@matejcerny
Copy link

matejcerny commented Apr 26, 2024

Unfortunately the contact which @tobimori used for pushing updates left Elgato, so we need to find another way. Do you have any experience with the Elgato store?

@malde
Copy link

malde commented Apr 26, 2024

Has that been tested? I couldn't get your version to work locally.
I did however find another fork that already did some v9 conversion, which does work (but has some issues with displaying the time, and could use some polishing): https://github.com/Barndtt/streamdeck-toggl

@jpcartailler
Copy link

Regarding the Elgato store - there is some information at https://docs.elgato.com/sdk/plugins/distribution.

Submit your plugins by sending an email to maker@elgato.com with the following:

Download: A link to download the plugin.

User: A unique username or an email address.

Release Notes: What changed with the new version of your plugin? (features/bug fixes)

Support: Where can users contact you if they have problems? (email, contact form, etc.)

Category: Under which category do you want to have your plugin listed in the store (only one category is allowed at the moment).

@angry-bender
Copy link
Contributor Author

Unfortunately the contact which @tobimori used for pushing updates left Elgato, so we need to find another way. Do you have any experience with the Elgato store?

Me personally, no, I havent even compiled a plugin locally unfortunately, was more looking to scope out the requirements before May to see what I need to learn, or if we could get an updated release 🫠

@tobimori
Copy link
Owner

"back then" compilation was just making a zip file with the elgato cli, not sure if that has changed much.

@matejcerny
Copy link

Sorry guys, as the change was not that big, I only tested it in postman. @malde You are right, I will try to fix it as soon as possible.

@matejcerny
Copy link

This one has been tested and it works. Sadly, the issue with displaying the time persists. Can anyone investigate it 🙏? #42

@angry-bender
Copy link
Contributor Author

angry-bender commented Apr 30, 2024

Just by downloading your zip, and replacing the contents in the %appdata%\elgato\StreamDeck\Plugins\io.moeritz.streamdeck.toggl.sdplugin it appears to work for time tracking.

I don't see the time issues in my version of toggl 😊

Similar to other repos listed in this issue, might be good to update the readme with the instructions so people don't think they need to recompile 😊

Thank you

@matejcerny
Copy link

This is how it looks like.

image

@malde
Copy link

malde commented Apr 30, 2024

Now that I see the full number (I didn't because font-size), I'm pretty sure that's just a local datetime conversion issue on the deck. Those 476,238 hours at least match the hours since 1.1.1970.

@matejcerny
Copy link

matejcerny commented Apr 30, 2024

Well, it looks like API does not send a duration anymore:

{
    ...
    "task_id": null,
    "billable": false,
    "start": "2024-04-30T06:43:55+00:00",
    "stop": null,
    "duration": -1,
    "description": "work",
    "tags": [],
    "tag_ids": [],
    "duronly": true,
    "at": "2024-04-30T06:43:56+00:00",
    "server_deleted_at": null,
    ...
    "permissions": null
}

@matejcerny
Copy link

Works on my machine. @malde Can you please also test it? Thanks a lot! #43

@malde
Copy link

malde commented Apr 30, 2024

Looks to be working for me 👍

@angry-bender
Copy link
Contributor Author

angry-bender commented Apr 30, 2024

This is how it looks like.

image

Ahh I removed that text In the UI for my use case 😊. Looks to be an epoch time.

@matejcerny
Copy link

matejcerny commented Apr 30, 2024

I already fixed it in #43 @angry-bender, can you please also test it? To check that there is no problem with the timezone.

@angry-bender
Copy link
Contributor Author

Looks to be right for me
image

@matejcerny
Copy link

Hopefully the last change: (#45)

@matejcerny
Copy link

Regarding the Elgato store - there is some information at https://docs.elgato.com/sdk/plugins/distribution.

Submit your plugins by sending an email to maker@elgato.com with the following:

Download: A link to download the plugin.

User: A unique username or an email address.

Release Notes: What changed with the new version of your plugin? (features/bug fixes)

Support: Where can users contact you if they have problems? (email, contact form, etc.)

Category: Under which category do you want to have your plugin listed in the store (only one category is allowed at the moment).

@tobimori Can you please send it as an author? This is the bundle, just delete the .md extension (I was unable to upload it here without it)

io.moeritz.streamdeck.toggl.streamDeckPlugin.md

@angry-bender
Copy link
Contributor Author

Regarding the Elgato store - there is some information at https://docs.elgato.com/sdk/plugins/distribution.

Submit your plugins by sending an email to maker@elgato.com with the following:

Download: A link to download the plugin.

User: A unique username or an email address.

Release Notes: What changed with the new version of your plugin? (features/bug fixes)

Support: Where can users contact you if they have problems? (email, contact form, etc.)

Category: Under which category do you want to have your plugin listed in the store (only one category is allowed at the moment).

@tobimori Can you please send it as an author? This is the bundle, just delete the .md extension (I was unable to upload it here without it)

io.moeritz.streamdeck.toggl.streamDeckPlugin.md

Looks like it's published https://marketplace.elgato.com/product/toggl-b040b224-5e61-4722-957f-91a662792441

@tobimori
Copy link
Owner

thanks all for your efforts with this and sorry I wasn't able to provide more assistance than this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants