Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart shows last date multiple times when selecting country #1

Closed
tobinatore opened this issue Mar 27, 2020 · 2 comments
Closed

Chart shows last date multiple times when selecting country #1

tobinatore opened this issue Mar 27, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tobinatore
Copy link
Owner

When selecting a country via the dropdown or the table, the chart updates accodingly but displays the last date multiple times.

@tobinatore tobinatore added the bug Something isn't working label Mar 27, 2020
@tobinatore tobinatore self-assigned this Mar 27, 2020
@tobinatore
Copy link
Owner Author

tobinatore commented Mar 28, 2020

So what I got by inspecting the database is, that apparently the 26th has been saved multiple times. I think that when there was no new data in the JHU CSSE's repository at 12 AM the update_db function was called multiple times and saved the 26th each time. I'll add the condition that it has to be after 1 AM (the CSSE repo is updated around 00:50 AM), before my app tries to update the records. We'll see if that fixes it tonight.

tobinatore added a commit that referenced this issue Mar 28, 2020
As outlined in #1 , this should hopefully stop multiple entries being
generated for the same date.
@tobinatore
Copy link
Owner Author

So what I got by inspecting the database is, that apparently the 26th has been saved multiple times. I think that when there was no new data in the JHU CSSE's repository at 12 AM the update_db function was called multiple times and saved the 26th each time. I'll add the condition that it has to be after 1 AM (the CSSE repo is updated around 00:50 AM), before my app tries to update the records. We'll see if that fixes it tonight.

So apparently that was indeed the problem. I've moved the time when the database gets updated to 3 AM CET, so there should be no more problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant