Offline region feature #336

kleeb · 2020-06-22T17:26:24Z

Added iOS and Android handling of the great Mapbox feature, which allows to download and cache dynamically selected region during the app usage.

disabled debug mode

Add mapbox offline dependency.

- handle null metadata - handle delete region that not exists in db

…ter-mapbox-gl into feature/offline

Feature/offline

…into tobrun-master

Dependencies from git

…into feature/offlinesync

AAverin · 2020-09-07T10:29:06Z

Does this leverage offline plugin too https://docs.mapbox.com/android/plugins/overview/offline/ ?
When downloading large maps for offline use, user should be able to dismiss the application and download should continue.
iOS documentation of Mapbox SDK is scarce, I only found this: https://docs.mapbox.com/ios/maps/examples/offline-pack/
Not sure if there is also some kind of plugin that can be used, or if iOS SDK supports background downloads out of the box.
@m0nac0 do you have any insight on that?

AAverin · 2020-09-08T09:14:21Z

lib/src/global.dart

+    },
+  );
+  Iterable regions = json.decode(regionsJson);
+  return regions.map((region) => OfflineRegion.fromJson(region)).toList();


As as suggestion, we could follow this article https://flutter.dev/docs/cookbook/networking/background-parsing
and put json parsing into compute, moving it to the background.

Same for other places that parse json

joandervieira · 2020-11-03T17:52:03Z

Hi, how is this PR ? any chances for merging ? I'm really waiting for this PR to be approved in order to use it

tobrun

Amazing work @kleeb
Would you able to patch the remarks made?
Or if someone else is up for patching?

Looking forward getting this merged, apologies for the delay

tobrun · 2020-11-07T09:23:46Z

android/build.gradle

@@ -40,6 +40,7 @@ android {
        implementation "com.mapbox.mapboxsdk:mapbox-android-sdk:9.2.0"
        implementation "com.mapbox.mapboxsdk:mapbox-android-plugin-annotation-v9:0.8.0"
        implementation "com.mapbox.mapboxsdk:mapbox-android-plugin-localization-v9:0.12.0"
+        implementation "com.mapbox.mapboxsdk:mapbox-android-plugin-offline-v8:0.6.0"


Could you use offline-v9 instead? Plugins have the major version of the maps SDK appended to them.

tobrun · 2020-11-07T09:24:28Z

android/src/main/java/com/mapbox/mapboxgl/GlobalMethodHandler.java

@@ -61,6 +75,14 @@ private InputStream openTilesDbFile(String tilesDb) throws IOException {
        }
    }

+    private String extractAccessToken(MethodCall methodCall, String fallbackValue) {
+        if (methodCall.hasArgument("accessToken")) {


Could you look into patching this @kleeb ?

kleeb · 2020-11-09T08:54:46Z

Unfortunately not. We lost all developers that were contributing. Can any of you finish this up?

lfofelipe · 2020-11-12T04:12:21Z

Hi guys. I created a fork with the suggested corrections and I already merged with master (0.9.0). I have a project to go into production and I couldn't wait any longer. Whoever needs this functionality, can use my fork directly in the project while I do the PR correctly.
Replace the mapbox_gl package with proper indentation:

  mapbox_gl:
    git:
      url: https://github.com/lfofelipe/flutter-mapbox-gl.git
      ref: master

Comments:

To work on ios, fill in info.plist:

<key>MGLMapboxAccessToken</key>
<string>YOUR_KEY_HERE</string>

Sometimes the example screen "Offline Regions" is not working (I didn't have time to check why)
Tested on iOS and Android (virtual devices seem to give connection problems, test on real devices)

I will make corrections appropriately in the coming days.
If someone can create a PR by correcting the problem of the "Offline Regions" screen example from my fork, this would be absurdly quick to merge.

Besides assigning the information that the key should exist in the info.plist ...

lfofelipe · 2020-11-13T07:28:14Z

The issue "Sometimes the example screen "Offline Regions" is not working (I didn't have time to check why)" has been fixed on my fork

kleeb · 2020-11-13T14:16:12Z

@lfofelipe would you manage to solve all conflicts between my branch and your fork ?
This would speed up the process of putting it to master

@tobrun @m0nac0 what do you think ?

lfofelipe · 2020-11-13T22:23:25Z

@lfofelipe would you manage to solve all conflicts between my branch and your fork ?
This would speed up the process of putting it to master

@tobrun @m0nac0 what do you think ?

Done.

sync with bugfix branch

kleeb · 2020-11-14T19:29:43Z

@tobrun @m0nac0
bugfix branch fixed

lfofelipe · 2020-12-09T18:36:09Z

25 days and no merge ? :(

felix-ht · 2020-12-10T16:15:43Z

@tobrun hows the status for a merge?

tobrun · 2020-12-19T07:19:50Z

25 days and no merge ?

Sorry about that, I'm only able to dedicate a Saturday per month to the project.
If you are interested in becoming a maintainer, please hit me up on email!

kleeb · 2020-12-22T09:43:11Z

Sweet! Thanks a lot guys and all contributors.

gabeschine · 2021-01-03T18:03:28Z

Hey just wanted to say THANK YOU for your time implementing this feature. Nice work :).

philiplindberg · 2021-01-06T16:17:57Z

First of all, thank you @kleeb and contributors for implementing this awesome feature 👍

I did want to make you aware of a potential bug I found when testing the example app on iOS. In offline_regions.dart, if you use downloadOfflineRegionStream instead of downloadOfflineRegion to download a particular region, the following exception is raised on iOS:

PlatformException (PlatformException(Downloading error, The operation couldn’t be completed. HTTP status code 401, null, null))

Seems to be an issue with the Mapbox access token not being properly set, even though I've defined ACCESS_TOKEN in main.dart. Again, this only seems to be happening on iOS and with the downloadOfflineRegionStream method (as opposed to downloadOfflineRegion, which works fine).

Interestingly enough, I've found that setting MGLMapboxAccessToken in Info.plist to the same access token defined in main.dart prevents the exception from being thrown.

kleeb · 2021-01-07T15:21:05Z

Thanks @philiplindberg for letting me know. Will check on that.
If you manage to reproduce and fix would be also awesome.

tantzygames · 2021-02-12T21:54:21Z

I've been using Flutter_map and can cache a mapbox instance for each session, which is important as a user can open quite a few map views in my app, and mapbox charges for each time the access token is used.

I've been working towards swapping to Mapbox_gl, but it seems to require a new Mapbox instance every time a map is opened. I've tried to cache the MapboxMap, but it creates a new instance with a new controller each time.

As well as caching a region, could this also cache a Mapbox instance for a whole session?

AAverin · 2021-02-13T07:39:59Z

@Kretin1 I think this is tracked here #245
There is no solution yet to have single reusable instance, but using keepAlive mixin seemed to have worked for my case so far

kleeb and others added 30 commits January 9, 2020 11:53

Update MapboxMapBuilder.java

307d136

disabled debug mode

Models for offline structure.

6fbde64

Add mapbox offline dependency.

Extract function for getting mapbox.

423bed2

Download region

3e580b8

Handle downloading region stream.

c6c6794

Download regions data.

0fa5cb3

Delete region

f512e84

Fix:

c8e5a54

- handle null metadata - handle delete region that not exists in db

WIP example

3473e19

Rename region.

a554cd9

WIP

27044f2

Show offline map.

0fb41b2

refactor

fcd2923

Update android dependencies.

206bd4a

Fixes

bccf419

Working or iOS offline maps implementation

9963f57

Merge branch 'feature/offline' of https://github.com/Asasello225/flut…

caf2790

…ter-mapbox-gl into feature/offline

Finished iOS offline maps implementation

2af6e9d

Merge branch 'master' into feature/offline

69f091f

test dependencies from git

c5cc0df

Merge pull request #5 from Asasello225/feature/offline

a276ba5

Feature/offline

add git dependencies

95aa106

Merge branch 'master' of https://github.com/tobrun/flutter-mapbox-gl …

71406f6

…into tobrun-master

Merge branch 'tobrun-master' into feature/offline

4ec5104

change git urls to https

0d7d5aa

Merge pull request #7 from andrea689/dependencies-from-git

f14408a

Dependencies from git

Merge branch 'master' of https://github.com/tobrun/flutter-mapbox-gl …

16456e7

…into feature/offlinesync

Update MapboxMapController.java

7d9d5f2

Update MapboxMapController.java

8b2b8a0

Delete MapBoxUtils.java

2a82c18

This was referenced Sep 6, 2020

offline mapbox #398

Closed

How to create cache.db? I can't find the way #387

Closed

AAverin reviewed Sep 8, 2020

View reviewed changes

tobrun reviewed Nov 7, 2020

View reviewed changes

luis felipe de oliveira added 2 commits November 11, 2020 22:04

Corrections from review and merge to master (0.9.0)

3d696a2

correcao

7b61a8a

CORRECTION

7fb27ee

Merge branch 'feature/offlinesync' into master

d69105e

Merge pull request #16 from lfofelipe/master

4a139ee

sync with bugfix branch

tobrun approved these changes Dec 19, 2020

View reviewed changes

tobrun merged commit 9fb4d52 into flutter-mapbox-gl:master Dec 19, 2020

shroff mentioned this pull request Dec 21, 2020

[offline][android] use region ids provided by MB + code cleanup #491

Merged

tantzygames mentioned this pull request Jan 4, 2021

Cache Mapbox instance #498

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline region feature #336

Offline region feature #336

kleeb commented Jun 22, 2020

AAverin commented Sep 7, 2020

AAverin Sep 8, 2020

AAverin Sep 8, 2020

joandervieira commented Nov 3, 2020

tobrun left a comment

tobrun Nov 7, 2020

tobrun Nov 7, 2020

kleeb commented Nov 9, 2020

lfofelipe commented Nov 12, 2020 •

edited

lfofelipe commented Nov 13, 2020

kleeb commented Nov 13, 2020

lfofelipe commented Nov 13, 2020

kleeb commented Nov 14, 2020

lfofelipe commented Dec 9, 2020

felix-ht commented Dec 10, 2020

tobrun commented Dec 19, 2020

kleeb commented Dec 22, 2020

gabeschine commented Jan 3, 2021

philiplindberg commented Jan 6, 2021

kleeb commented Jan 7, 2021

tantzygames commented Feb 12, 2021

AAverin commented Feb 13, 2021

Offline region feature #336

Offline region feature #336

Conversation

kleeb commented Jun 22, 2020

AAverin commented Sep 7, 2020

AAverin Sep 8, 2020

Choose a reason for hiding this comment

AAverin Sep 8, 2020

Choose a reason for hiding this comment

joandervieira commented Nov 3, 2020

tobrun left a comment

Choose a reason for hiding this comment

tobrun Nov 7, 2020

Choose a reason for hiding this comment

tobrun Nov 7, 2020

Choose a reason for hiding this comment

kleeb commented Nov 9, 2020

lfofelipe commented Nov 12, 2020 • edited

lfofelipe commented Nov 13, 2020

kleeb commented Nov 13, 2020

lfofelipe commented Nov 13, 2020

kleeb commented Nov 14, 2020

lfofelipe commented Dec 9, 2020

felix-ht commented Dec 10, 2020

tobrun commented Dec 19, 2020

kleeb commented Dec 22, 2020

gabeschine commented Jan 3, 2021

philiplindberg commented Jan 6, 2021

kleeb commented Jan 7, 2021

tantzygames commented Feb 12, 2021

AAverin commented Feb 13, 2021

lfofelipe commented Nov 12, 2020 •

edited