Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][Example] Added web support for fills #501

Merged
merged 6 commits into from
Feb 12, 2021

Conversation

felix-ht
Copy link
Collaborator

@felix-ht felix-ht commented Jan 7, 2021

resolves #438 and resolves #471

Limitations:

  • Fill pattern is currently ignored. The reason for this is that is seems that fill-pattern has to be set on a per layer basis. Causing the fill creation to fail if no Pattern is specified.

I also formatted all files i touched with flutter format. If this is an issue i can change that - however i think that it would be a good idea to run flutter format in the ci - so that formatting is consistent.

@felix-ht
Copy link
Collaborator Author

felix-ht commented Jan 7, 2021

note that dragging a fill currently translates the fill in a somewhat weird way (It jumps as soon as the drag starts), as there seems to be no drag start event, to get the initial coordinates of the drag.
Dragging now works as expected

@felix-ht felix-ht changed the title WIP added web support for fills Added web support for fills Jan 8, 2021
@felix-ht felix-ht changed the title Added web support for fills [Web][Example] Added web support for fills Jan 11, 2021
@tobrun tobrun merged commit 2209305 into flutter-mapbox-gl:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addFill() implementation does not use its data parameter Add Fill Layer support for Web implementation
2 participants