Fix: style annotation is not deselected #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `deselectStyleAnnotation` is called synchronously in this delegate callback, the operation silently fails and the selected appearance for the annotation (typically, a blue tinted overlay) remains. This is an unexpected state, since the flutter-mapbox-gl wrapper does not track annotation selection and has no way to remove it. If the annotation itself is removed, the selection remains visible on the map. If we call `deselectStyleAnnotation` asynchronously, the selection is removed as expected an is not visible to the user as a tinted overlay.
4F2E4A2E
approved these changes
Feb 5, 2021
4F2E4A2E
approved these changes
Feb 5, 2021
tobrun
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
deselectStyleAnnotationis called synchronously in this delegatecallback, the operation silently fails and the selected appearance for
the annotation (typically, a blue tinted overlay) remains. This is an
unexpected state, since the flutter-mapbox-gl wrapper does not track
annotation selection and has no way to remove it. If the annotation
itself is removed, the selection remains visible on the map.
If we call
deselectStyleAnnotationasynchronously, the selection isremoved as expected an is not visible to the user as a tinted overlay.