Add heading to UserLocation and expose UserLocation type #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objects of this type are returned by framework methods, but client code and not refer to the type currently.
While UserLocation includes a "bearing" (also called "course") indicating the direction of travel, it does not expose the heading of the device. Since this information is already provided in the `didUpdate userLocation` delegate method, we can add it to the `UserLocation` payload for a trivial cost at runtime.
n8han
changed the title
UserLocation type
|
I don't think the web build failure is related to changes in this branch. |
|
Android feature request in #528 |
tobrun
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While UserLocation includes a "bearing" (also called "course")
indicating the direction of travel, it does not expose the heading of
the device. Since this information is already provided in the
didUpdate userLocationdelegate method, we can add it to theUserLocationpayload for a trivial cost at runtime.
Also exposes the existing UserLocation type so that client code may
refer to it.