Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to null-safety #607

Merged
merged 3 commits into from Apr 26, 2021
Merged

migrate to null-safety #607

merged 3 commits into from Apr 26, 2021

Conversation

morvagergely
Copy link
Contributor

This commit migrates all packages to null-safety. Solves #564.
Also updates dependencies.
Android compile SDK version changed from 28 to 29 and multidex support has been enabled.
queryRenderedFeatures now works on web.

@mendoxe
Copy link

mendoxe commented Apr 20, 2021

Hi, could this issue get more priority, please? It is the last not null-safe package for my project and I would like to migrate. Thanks in advance!

@andrea689
Copy link
Collaborator

@mendoxe If you want to migrate use this:

dependency_overrides:
  mapbox_gl:
    git:
      url: https://github.com/morvagergely/flutter-mapbox-gl.git
  mapbox_gl_platform_interface:
    git:
      url: https://github.com/morvagergely/flutter-mapbox-gl.git
      path: mapbox_gl_platform_interface
  mapbox_gl_web:
    git:
      url: https://github.com/morvagergely/flutter-mapbox-gl.git
      path: mapbox_gl_web

@mendoxe
Copy link

mendoxe commented Apr 20, 2021

@andrea689 Thank you, sir.

Btw. may I ask why isn't the package being migrated and one has to do a workaround like this?

@andrea689
Copy link
Collaborator

@mendoxe This is a community driven project, so the PR will be merged and a new version released when the maintainer has some time to do it. In the meantime, you can use the fork directly and proceed with the migration.

Copy link
Collaborator

@n8han n8han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I've tested this branch with my own app and haven't run into any issues. And it's nice to see a few latent bugs being fixed along the way.

I have a few comments and questions here.

Also, for other reviewers, I did not look at changes to examples and the web platform code. Someone who know the web codebase may want to take a closer look at that.

Copy link
Collaborator

@n8han n8han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but as I mentioned I didn't review the web platform code

@andrea689
Copy link
Collaborator

I've tried my apps (Android iOS and web) with this branch and there doesn't seem to be any problems.

@tobrun I think you should merge this PR as soon as possible so that the next developments can be done on an NNBD basis.

@andrea689 andrea689 merged commit 6a907cd into flutter-mapbox-gl:master Apr 26, 2021
@hpoul
Copy link

hpoul commented Jul 12, 2021

Any plan on releasing a new version to pub which includes this pr? @andrea689 ?

@andrea689
Copy link
Collaborator

@tobrun makes the releases

@tobrun
Copy link
Collaborator

tobrun commented Jul 12, 2021

@tobrun makes the releases

yes, I need to find a way for collaborators to be able to do this as well. Initially thinking to add collaborators with write access, now thinking about setting up a CD pipeline through git tags..

@supposedlysam-bb
Copy link

Would appreciate any update on this @tobrun. Were you able to set up a CD pipeline or manually release it to the pub?

@pitazzo
Copy link

pitazzo commented Sep 13, 2021

Also interested into getting this PR released!

@DmitriyYakovlev
Copy link

any news regarding null-safety release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants