Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust 1.26 attribute regression #15

Closed
toby opened this issue Apr 13, 2018 · 3 comments
Closed

Fix Rust 1.26 attribute regression #15

toby opened this issue Apr 13, 2018 · 3 comments
Labels

Comments

@toby
Copy link
Owner

toby commented Apr 13, 2018

From: rust-lang/rust#49934

Looks like Rust 1.26 breaks our build.

@toby toby added the bug label Apr 13, 2018
@chpio
Copy link
Contributor

chpio commented Apr 13, 2018

maybe im just blind, but where's the error: https://cargobomb-reports.s3.amazonaws.com/beta-1.26.0-beta.2/beta-2018-04-06/reg/serde_bencode-0.2.0/log.txt

current master compiles/tests just fine on current nightly (1.27.0-nightly (ad610bed8 2018-04-11))

@toby
Copy link
Owner Author

toby commented Apr 13, 2018

@chpio I also didn't parse an error out of that. I was going to build it with 1.26 after work today to see what was up. If nothing else, this ticket can be to go back and tell them there's no problem :)

@madadam
Copy link
Collaborator

madadam commented Nov 11, 2021

Minimal rust version required by this crate is now 1.40.0. I'm closing this, but feel free to create a new issue if you need it to support older rusts.

@madadam madadam closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants