-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Statistics are not saved, starting from zero after restart of the docker image #133
Comments
I believe this would depend on how Zoraxy itself caches statistics. If it caches to a specific location, you could create a volume for it. I'll have to wait and see what Toby says to know for sure |
Cannot reproduce this bug while running Zoraxy natively without docker. @PassiveLemon For your information, the statistic is stored in memory and only write to |
The file sys.db already existed yesterday; I just checked if the modified time updated since:
The file also grew a bit since yesterday. Also, I just shut down and restarted the container - yesterday's stats were indeed saved. Everything since (today's stats) were thrown away - the file did not grow a bit. File info after the restart:
|
Ok, this surely seems like a "docker not gracefully closing zoraxy" issue. I will let @PassiveLemon take over from here. Thanks for the bug report! |
That would make sense, there is no graceful shutdown implemented in the container. Docker sends out a SIGTERM to the running process (shell in this case) but it doesn't respond to it so, after the grace period, it SIGKILLs everything which would result in an improper save. |
This seems to be happening again with Zoraxy 3.0.4, works fine on 3.0.3 |
Describe the bug
Statistics are not saved, starting from zero after restart of the docker image.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Statistics get saved and are loaded after every restart of the docker image.
Additional context
The docker image is setup with a volume to save data/config across sessions:
Configs like the set up proxy hosts and custom access lists get saved there; stats not so much.
The text was updated successfully, but these errors were encountered: