Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENTS] Dissallow old TLS Versions #21

Closed
PMFRTT opened this issue Jun 9, 2023 · 4 comments
Closed

[ENHANCEMENTS] Dissallow old TLS Versions #21

PMFRTT opened this issue Jun 9, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@PMFRTT
Copy link

PMFRTT commented Jun 9, 2023

Is your feature request related to a problem? Please describe.
When doing a Security-Scan of my environment, i received the warning, that TLS 1.0 and 1.1 are still available on port 443:
image

Describe the solution you'd like
There should be a way to disable the use of such old and deprecated versions of TLS.

@PMFRTT PMFRTT added the enhancement New feature or request label Jun 9, 2023
@tobychui
Copy link
Owner

tobychui commented Jun 9, 2023

I agree, but I am following the Golang team decision regarding the default minimum supported TLS versions of the tls listener.

I just take a look at the code, it would be a really easy thing to do by just hard code the min version into it like this.

//mod/dynamicproxy/dynamicproxy.go
	config := &tls.Config{
		GetCertificate: router.Option.TlsManager.GetCert,
		MinVersion:     tls.VersionTLS12,
	}

But for some user that might be using legacy systems, it is better not to hard code it. I think I can add a way to let user pick which minimum version to be used, but it won't be a simple checkbox or dropdown as Zoraxy is more designed for entry level users. I will come back to this enhancement once I figure out a better implementation of the UX for this function.

@PMFRTT
Copy link
Author

PMFRTT commented Jun 9, 2023

I agree, but I am following the Golang team decision regarding the default minimum supported TLS versions of the tls listener.

I just take a look at the code, it would be a really easy thing to do by just hard code the min version into it like this.

//mod/dynamicproxy/dynamicproxy.go
	config := &tls.Config{
		GetCertificate: router.Option.TlsManager.GetCert,
		MinVersion:     tls.VersionTLS12,
	}

But for some user that might be using legacy systems, it is better not to hard code it. I think I can add a way to let user pick which minimum version to be used, but it won't be a simple checkbox or dropdown as Zoraxy is more designed for entry level users. I will come back to this enhancement once I figure out a better implementation of the UX for this function.

Yes! Thanks for the input. Edited the file and build from source. Now the server only serves with TLS1.2 and TLS1.3. I'm only using Zoraxy for private service so I know, that all of the devices connecting will support the newest version. Backwards compatibility is not a concern for me.

@tobychui
Copy link
Owner

圖片
I added this feature under the advance setting menu in the upcoming 2.6.5.

@tobychui
Copy link
Owner

Feature added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants