Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be name and id fields in ConceptGraphRecord #289

Open
tobydragon opened this issue Jun 1, 2018 · 0 comments
Open

should be name and id fields in ConceptGraphRecord #289

tobydragon opened this issue Jun 1, 2018 · 0 comments

Comments

@tobydragon
Copy link
Owner

Currently there is only 1 field, name, on a conceptGraphRecord sent to the system. This doesn't hold a name, but rather the ID. THis is because these strings come from CohortConceptGraphs constructor, where it is using the same string as a key for a hasmap, so it has to be unique.

Done when: Both pieces of information are shared correctly in ConceptGraphRecord (and therefore CohortConceptGraphsRecord) so that the final users of the API get both name and ID, and therefore can choose what to display, but also have a unique identifer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant