Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1841] Liquidity fails to exclude shares of new Non-historical companies #9502

Open
physic opened this issue Aug 28, 2023 · 0 comments
Open
Labels
1841 minor bug A minor bug that doesn't impact game play (erronous logging)

Comments

@physic
Copy link

physic commented Aug 28, 2023

https://18xx.games/game/132855?action=816

Here are 5 scenarios where a share is not liquid.

President's Cert that may not be dumped: Correct
Shares that may not be sold due to 50% pool limit: Correct
Historical Company just parred: Correct
Non-historical Company just parred: Not accounted for.
Merged company has not operated yet: Not accounted for.

In the attached game state, Alexfrog's Liquidity is calculated to be his entire net worth, even though the IFAI share has never operated and may not be sold. Furthermore, having a player float a company and buy 4 shares at 68, you will see their liquidity is reduced by only L.136 (for the illiquid Pres.Cert) when it should be reduced by L.272

@roseundy roseundy added minor bug A minor bug that doesn't impact game play (erronous logging) 1841 and removed needs triage labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1841 minor bug A minor bug that doesn't impact game play (erronous logging)
Projects
None yet
Development

No branches or pull requests

2 participants