Refactor: move JSON path generation logic in Generator #2920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses items (1) and (2) mentioned in the "to do" section of #2914.
Transpiling
*
is a little more nuanced and requires more investigation, because despite some dialects not supporting this syntax, I think it may still be possible to simulate it by simply omitting it. For example, in DuckDB you can do:But in BigQuery this syntax is not supported, since they don't recognize the
*
inside the brackets ("Unsupported operator in JSONPath: *"). However, if we completely omit the brackets, it seems like the result matches:The exact same thing holds e.g. for Trino. Not sure if we wanna solve this now, though.