fix: have table exclude this if schema target #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Feb 6, 2024
tobymao
reviewed
Feb 6, 2024
georgesittas
reviewed
Feb 6, 2024
eakmanrq
force-pushed
the
eakmanrq/fix_schema_parsing
branch
from
bce9bd7
to
7699917
Compare
eakmanrq
force-pushed
the
eakmanrq/fix_schema_parsing
branch
from
7699917
to
8336f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change table objects which were the target of
CREATE SCHEMAorDROP SCHEMAwould set this as the db name and then db as the catalog name (if provided). The rendered SQL is fine but if we call something likequalify_tableon the expression and try to set a catalog if one does not exist then it will add the catalog when it is not needed since it will see the catalog filed as None when really catalog is set but it is just set in thedbfield.