Feat(clickhouse): add support for LIMIT BY clause #2926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://tobiko-data.slack.com/archives/C0448SFS3PF/p1707220020280219.
Based on https://clickhouse.com/docs/en/sql-reference/statements/select/limit-by, it seems like we can also have
LIMIT n OFFSET offset_value BY expressions
This PR doesn't handle this version properly, at least not yet. I wasn't sure how we wanna do this, provided that
OFFSET
is treated as a separate modifier. Should we just add anexpressions
arg toexp.Offset
and do something similar in its parser / generator?