fix: Fix Hive UnixToTime regression, README stale results #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of validating the README examples, 2 diffs with current SQLGlot results were found:
The first example transpiled
EPOCH_MS (DuckDB) -> FROM_UNIXTIME (Hive)but the respective AST Nodeexp.UnixToTimewas not generating properly in HiveThe parse error examples in the existing README have mismatches in the
colposition of the missing token (right parenthesis) and the surrounding context does not seem right. In the latest SQLGLot version, the parse error diagnostics have improved but the examples have not been updated.