Oracle - insert append - error parsing hint

[sunrutcon]

Error in parsing Oracle insert append.

SQL

-- Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - Production
select banner from v$version;
-- create table
create table iap_tbl (id int, col1 varchar2(20 char));
/
-- normal insert
insert into iap_tbl (id, col1) values (1, 'test');
commit;
/
select * from iap_tbl;
/
-- insert with append hint
insert /*+ append */ into iap_tbl (id, col1) values (2, 'test2');
commit;

Python

# pip show sqlglot
#Name: sqlglot
#Version: 22.2.0

from sqlglot import parse_one

# error parsing hint
sql_nok = "insert /*+ append */ into iap_tbl (id, col1) values (2, 'test2')"

# ok when + removed from comment, normal comment not hint
sql_ok = "insert /* append */ into iap_tbl (id, col1) values (2, 'test2')"

parse_one(sql_ok)

parse_one(sql_nok)

[tobymao]

@sunrutcon this should be relatively easy to handle, would appreciate if you took the time to contribute a pr,

in _parse_insert, handle the insert hint

[sunrutcon]

I'm working on it. I'll try to solve this until the end of the week.

[VaggelisD]

Hi @sunrutcon, I've already started looking at this and I expect to have it fixed by tonight, apologies for the late notice. Thanks for reporting this and feel free to report and/or contribute your fixes for any other issues you encounter.