Fix(redshift): don't transform multi-arg DISTINCT clause #3079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redshift's aggregation function syntax generally expects
[ DISTINCT | ALL ] expression
, butLISTAGG
is an exception:[DISTINCT] aggregate_expression [, 'delimiter' ]
.I didn't address this as a special case, but rather made it so that Redshift doesn't transpile multi-arg
DISTINCT
expressions at all. The reason is that I played around and realized that Redshift probably doesn't support tuples ("records"?) in that context, so transpiling a query with a multi-argDISTINCT
expression to Redshift would yield invalid SQL anyway:References: