Refactor!(optimizer): only create scopes for the DDL queries #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to create Scopes for both Query and DDL expressions, but the logic that handled the latter was brittle, incomplete and resulted in another expression type that users of the Scope module had to take into account, thus making the interface more complex to use. This makes it so that we'll only optimize the _queries_ of statements such as CTAS and INSERT INTO, instead of the whole thing. Same holds for lineage inference - we'll only analyze the DDL queries.
barakalon
reviewed
Mar 7, 2024
tobymao
reviewed
Mar 7, 2024
tobymao
approved these changes
Mar 8, 2024
georgesittas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to create Scopes for both Query and DDL expressions, but the logic that handled the latter was brittle, incomplete and resulted in another expression type that users of the Scope module had to take into account, thus making the interface more complex to use.
This makes it so that we'll only optimize the queries of statements such as CTAS and INSERT INTO, instead of the whole thing. Same holds for lineage inference - we'll only analyze the DDL queries.
Fixes #3086