Fix!: StrToUnix Hive parsing, Presto generation fixes #3225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3221
There were a couple of issues here. The first one is:
This
DATE_PARSE
call is invalid in Presto / Trino - we need an argument to parse.The second one was a bit more nuanced and I don't really like my current solution, but didn't see another way out during my investigation. Basically,
DATE_PARSE
doesn't handle time zone information, and so the following breaks in Presto:The workaround I implemented it basically to try calling both
DATE_PARSE
andPARSE_DATETIME
, because if the former fails due to encountering a time zone, the latter will parse it just fine. There was a refactor to allowformat_time
to use different time format bindings, sincePARSE_DATETIME
supports different date/time formats.References: