Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(prql): Add FILTER #3291

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Feat(prql): Add FILTER #3291

merged 8 commits into from
Apr 9, 2024

Conversation

fool1280
Copy link
Contributor

@fool1280 fool1280 commented Apr 9, 2024 •
edited

  1. Add support for FILTER: https://prql-lang.org/book/reference/stdlib/transforms/filter.html
  2. Add support for APPEND, REMOVE, INTERSECT (some are experimental in prql): https://prql-lang.org/book/reference/stdlib/transforms/append.html

georgesittas
georgesittas reviewed Apr 9, 2024
View reviewed changes
sqlglot/dialects/prql.py Outdated Show resolved Hide resolved
sqlglot/dialects/prql.py Outdated Show resolved Hide resolved
sqlglot/dialects/prql.py Outdated Show resolved Hide resolved
@georgesittas
Copy link
Collaborator

@tobymao what do you think about moving select_all to expressions.py? It seems like we use it in a few places.

@tobymao
Copy link
Owner

tobymao commented Apr 9, 2024

@tobymao what do you think about moving select_all to expressions.py? It seems like we use it in a few places.

sure

@georgesittas georgesittas merged commit eabb708 into tobymao:main Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fool1280 @georgesittas @tobymao