feat!: Introducing TIMESTAMP_NTZ token and data type #3386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3379
Introduce token & datetype
TIMESTAMP_NTZ
in order to preserve the round-trip of allTIMESTAMP_*
variations.Both Spark3/DB and Snowflake allow
TIMESTAMP
to be configured to either_LTZ
or_NTZ
(Spark3/DB default to the former, Snowflake to the latter) in a session, so this PR also aims to holistically fix these hardcoded/lossy SQLGlot mappings.Docs